-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
fix: proxy_base_url on the Proxy UI #11077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const nextConfig = { | ||
| output: 'export', | ||
| basePath: process.env.UI_BASE_PATH || '/ui', | ||
| baseProxyUrl: process.env.PROXY_BASE_URL || '/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @wagnerjt could you explain what happens when this value is set on nextconfig?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since our UI is rendered from the server as static html - how is this change used ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During the custom UI build process, nextjs will recognize if this environment variable is set and inject the variable.
Something like RUN UI_BASE_PATH=${UI_BASE_PATH} npm run build.
To be even more dynamic, we could make anl new endpoint on the python server that returns the env variables for the UI on startup. Would this be preferred?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Proxy UI using PROXY_BASE_URL
Relevant issues
Handles #10761
Pre-Submission checklist
Type
🐛 Bug Fix
🧹 Refactoring
Changes
UI Proxy respecting the the
PROXY_BASE_URL.